Task 145

salmankhawar

My result comes out correct, but I get the 'exceeded execution timeout of 40 seconds' error.
I have done this:

export const shortenByWords = (s, n) => {
if(s.length > n) {
for(let i = n + 1; i > 0; i++) {
if(s === ' '){
return s.slice(0, i) + '...';
}
}
} else {
return s
}
}

Coderslang_Master

salmankhawar could you explain the condition of your for loop? It's unclear what you intend by let i = n + 1; i > 0; i++

P.S. For future tasks also include the task description and submission results. Maybe as screenshots.

salmankhawar

Okay I copied the wrong one, here's the correct one.:
export const shortenByWords = (s, n) => {
if(s.length > n) {
for(let i = n; i < s.length; i++) {
if (s === ' ')

  
return s.slice(0, i) + '...';

}
} else {
return s
}
}

Results Screenshot here:

salmankhawar

Did some changes:

export const shortenByWords = (s, n) => {
  if(s.length > n) {
    for(let i = 0; i < s.length; i++){ 
      if (s[i] === ' ' && i > n) return s.slice(0, i) + '...';
    }
  } else {
    return s
  }
}

Coderslang_Master

salmankhawar consider a case where s.length > n is true but s[i] === ' ' && i > n is always for (for every i). In this case, your code returns undefined.

salmankhawar

Coderslang_Master doesn't return close the loop after finding the first i which is ' ' and is more than n?

Coderslang_Master

salmankhawar it would, but what if there's no space?