task 132 • Localization

alxjspalma

As you show in this task, parameters in a function can have the same name as a correspondent argument, right?

parameter in function.js

export const getLocale = (userConf, knownLocales) => {

argument in solution.js

console.log(getLocale(userConfig1, knownLocales));

alxjspalma

Another question! (I only changed the functions.js file.)
First I did the solution below...is it good?

export const getLocale = (user, known) => {
  if (user.locale == 'en' || user.locale == 'ru' || user.locale == 'es' || user.locale == 'it' || user.locale == 'fr') {
    return user.locale;
  } else {
    return 'en';    
  }
}

Then I thought that there must be a better way to do this, in case the string was much bigger!
After some research I came up with the solution, below...is it good?

export const getLocale = (user, known) => {
  
  const result = known.find(element => element == user.locale);

  if (result == user.locale) {
    return user.locale;
  } else {
    return 'en';    
  }
}

Coderslang_Master

In the first code snippet, you don't use the param known, so it's not good.

The second code snippet looks good, although at this stage you can use a plain for loop to get the same result. I don't think I've introduced array methods in lecture 13.

alxjspalma

Coderslang_Master Sorry, I didn't understand this "you can use a plain"! How can I solve it without those two solutions?

Coderslang_Master

@alxjspalma can you implement the same thing but without find?

  const result = known.find(element => element == user.locale);

try doing this with a single for loop.

MAmin

Coderslang_Master
Just for test I wrote the code as

const knownLocales = ['en', 'ru', 'es', 'it', 'fr']
const userConfig = { locale: 'ws' }

const getLocale = (userConfig, knownLocales) => {
  knownLocales.forEach(element => {
    if (true) {
      return 'ar'
    } else return 'en'
  })
}
console.log(getLocale(userConfig, knownLocales))

I expected that the output will be "ar", but the output was "undefined"
I can't understand why the output was "undefined"?

Coderslang_Master

MAmin the problem is that you're incorrectly using the forEach function. You'll get to it in future lectures. For now, I suggest you rewrite the same code using the plain for loop.