task 250 stage 12

Apostolos

I get these errors:

checkInitCompleted should be called from handleKeyPress if the user has enough gold to make first purchase
handleKeyPress arguments should be forwarded into checkInitCompleted
checkInitCompleted should be called from handleKeyPress only once for the life of the game

My code:

import { updateGold, checkInitCompleted } from "./functions.js";

export const handleKeyPress = (term, state) => {
    return (name, matches, data) => {
        let s = String.fromCharCode(data.code);
        if (s === 'G' || s === 'g') {
            state.gold++;
        } else {
            for (let i = 0; i < state.producers.length; i++) {
                if (s === String(state.producers[i].id)) {
                    state.gold -= state.producers[i].cost;
                    state.producers[i].cost = state.producers[i].cost * state.producers[i].growthRate;
                    state.producers[i].count++;
                    state.productionRate += state.producers[i].baseProduction;
                }
            }
        }
        if (!state.isInitCompleted) {
            for (let i = 0; i < state.producers.length; i++) {
                if (state.gold >= state.producers[i].cost) {
                    state.isInitCompleted = true;
                    checkInitCompleted(term, state);
                }
            }
        }  
    }
}

export const handleStateChange = (term, state) => {
    return () => { updateGold(term, state); }
}

`

`export const init = (term) => {
    term('Welcome to the mining game!');
    term.clear();
    term.hideCursor();
    term.grabInput();
}

export const updateGold = (term, state) => {
    term.moveTo(25, 2);
    term.eraseLineAfter();
    term.bold.yellow(state.gold + '   ');

    state.gold += state.productionRate;
}

export const checkInitCompleted = (term, state) => {
    term.clear();
    term.moveTo(25, 2);
    term('You can purchase producers by clicking the number button (1, 2, 3, ...)');
    term.moveTo(25, 2);
    term.eraseLineAfter();
    term(`GOLD: ${state.gold}`);
    term.moveTo(25, 2);
    term.eraseLineAfter();
    term(`PRODUCTION RATE: ${state.productionRate}`);
}

Coderslang_Master

Apostolos it's hard to read the code. Could you format it properly by adding three backticks in the lines before each code snippet and the one after?

It'll look like this:

export const checkInitCompleted = (term, state) => {
  term.clear();
  term.moveTo(25, 2);
  term('You can purchase producers by clicking the number button (1, 2, 3, ...)');
  term.moveTo(25, 2);
  term.eraseLineAfter();
  term(GOLD: ${state.gold});
  term.moveTo(25, 2);
  term.eraseLineAfter();
  term(PRODUCTION RATE: ${state.productionRate});
}

Coderslang_Master

Apostolos there's no reason to call checkInitCompleted in the loop. It should only be called once, exactly when you have enough gold for the initial purchase.

Apostolos

But that's the reason it is in the loop: to check if the gold is enough to purchase any of the producers, right?

Coderslang_Master

Apostolos that's a good point, but it does more harm than good as initially, you can only add gold by one and checkInitCompleted should be called only once during the course of the game.

Apostolos

Coderslang_Master

Coderslang_Master you can only add gold by one

what do you mean by that?

I still don't understand what is asked of me to do. The checkInitCompleted should be called after I have checked if the gold is enough to buy a producer, am I right?

Coderslang_Master

Apostolos yes you're right, as soon as you have enough gold to by the cheapest producer (10 gold), you should call checkInitCompleted

By "you can only add gold by one" I mean that there's no point to check every producer in the loop and you should only consider the cheapest one.

Apostolos

Coderslang_Master

Which one is the cheapest? Is he the first one? Or should I implement an if statement to find out?

Apostolos

Coderslang_Master

I'd like to move forward. Can I get some help? I've seen other member's posts in which they seem to have moved forward with the exact same code as the one I posted in the beginning. Any thoughts?

Coderslang_Master

Apostolos the cheapest producer is the one with the lowest cost.

Please post updated code and submission results so that I can give you another hint.

Apostolos

Coderslang_Master

if (!state.isInitCompleted) {
            cheapProd = state.producers[0];
            for (let i = 1; i < state.producers.length; i++) {
                if (cheapProd.cost > state.producers[i].cost) {
                    cheapProd = state.producers[i];
                }
            }
            if (state.gold >= cheapProd.cost){
                state.isInitCompleted = true;
                checkInitCompleted(term, state);
            }

        }

Coderslang_Master

Apostolos This piece of code looks ok, so if you still get errors they are somewhere else.

Apostolos

Here is everything then:
handlers.js:


export const handleKeyPress = (term, state) => {
    return (name, matches, data) => {
        let s = String.fromCharCode(data.code);
        if (s === 'G' || s === 'g') {
            state.gold++;
        } else {
            for (let i = 0; i < state.producers.length; i++) {
                if (s === String(state.producers[i].id)) {
                    state.gold -= state.producers[i].cost;
                    state.producers[i].cost = state.producers[i].cost * state.producers[i].growthRate;
                    state.producers[i].count++;
                    state.productionRate += state.producers[i].baseProduction;
                }
            }
        }
        if (!state.isInitCompleted) {
            cheapProd = state.producers[0];
            for (let i = 1; i < state.producers.length; i++) {
                if (cheapProd.cost > state.producers[i].cost) {
                    cheapProd = state.producers[i];
                }
            }
            if (state.gold >= cheapProd.cost){
                state.isInitCompleted = true;
                checkInitCompleted(term, state);
            }

        }
    }  
}

export const handleStateChange = (term, state) => {
    return () => { updateGold(term, state); }
}

functions.js:

    term('Welcome to the mining game!');
    term.clear();
    term.hideCursor();
    term.grabInput();
}

export const updateGold = (term, state) => {
    term.moveTo(25, 2);
    term.eraseLineAfter();
    term.bold.yellow(state.gold + '   ');

    state.gold += state.productionRate;
}

export const checkInitCompleted = (term, state) => {
    term.clear();
    term.moveTo(25, 2);
    term('You can purchase producers by clicking the number button (1, 2, 3, ...)');
    term.moveTo(25, 2);
    term.eraseLineAfter();
    term(`GOLD: ${state.gold}`);
    term.moveTo(25, 2);
    term.eraseLineAfter();
    term(`PRODUCTION RATE: ${state.productionRate}`);
}

constants.js:


export const term = terminalKit.terminal;

export const config = {
    gold: 0,
    producers: [{'id': 'id', 'title': 'title', 'cost': 'cost', 'growthRate': 'growthRate', 'baseProduction': 'baseProduction', 'count': 'count'}],
    productionRate: 0,
    isInitCompleted: false,
    isProducerListUpdated: true,
};

gameEngine.js:

import { handleKeyPress, handleStateChange } from './handlers.js';

export const startMiningGame = (term, state) => {
    init(term);
    term.on('key', handleKeyPress(term, state));
    setInterval(handleStateChange(term, state), 1000);
}

solution.js:

import { term, config } from './constants.js';

startMiningGame(term, config);

and i still get these errors:

checkInitCompleted should be called from handleKeyPress if the user has enough gold to make first purchase
handleKeyPress arguments should be forwarded into checkInitCompleted
checkInitCompleted should be called from handleKeyPress only once for the life of the game

Coderslang_Master

Apostolos the error is in this line:

cheapProd = state.producers[0];

You forgot to use the keyword let to declare the variable cheapProd.

Apostolos

Coderslang_Master

I corrected it. I still get the same three errors.

Coderslang_Master

Apostolos I took another look at your code. Have you missed (removed?) the imports in the first line of the file handlers.js?

If the imports are there and you just decided to not include them here, please review all the files and put all code here.

Apostolos

Coderslang_Master

No. For some reason it wasn't included in the quotation. Here is my handlers.js file:

import { updateGold, checkInitCompleted } from "./functions.js";

export const handleKeyPress = (term, state) => {
    return (name, matches, data) => {
        let s = String.fromCharCode(data.code);
        if (s === 'G' || s === 'g') {
            state.gold++;
        } else {
            for (let i = 0; i < state.producers.length; i++) {
                if (s === String(state.producers[i].id)) {
                    state.gold -= state.producers[i].cost;
                    state.producers[i].cost = state.producers[i].cost * state.producers[i].growthRate;
                    state.producers[i].count++;
                    state.productionRate += state.producers[i].baseProduction;
                }
            }
        }
        if (!state.isInitCompleted) {
            let cheapProd = state.producers[0];
            for (let i = 1; i < state.producers.length; i++) {
                if (cheapProd.cost > state.producers[i].cost) {
                    cheapProd = state.producers[i];
                }
            }
            if (state.gold >= cheapProd.cost){
                state.isInitCompleted = true;
                checkInitCompleted(term, state);
            }

        }
    }  
}

export const handleStateChange = (term, state) => {
    return () => { updateGold(term, state); }
}

Coderslang_Master

Apostolos I totally missed what you put into the producers array.

Here's an example of how your config should look like:

export const config = {
  isInitCompleted: false,
  isProducerListUpdated: true,
  gold: 0,
  productionRate: 0,
  producers: [
    { id: 1, title: 'Miner', cost: 10, growthRate: 1.13, baseProduction: 0.1, count: 0 },
    { id: 2, title: 'Adventurer', cost: 100, growthRate: 1.17, baseProduction: 1, count: 0 },
    { id: 3, title: 'Professional', cost: 1200, growthRate: 1.14, baseProduction: 9, count: 0 },
  ],
}

Apostolos

Coderslang_Master
It worked! Thank you