Task 145: shortenByWords

Kevo

Hi everyone
Having some trouble with Task 145, can't find where I'm going wrong. I've tried different approaches. The function works just fine with any given string, but I keep getting the execution timeout message. With other variations, I get the "must end with '...' if the string has to be shortened" requirement wrong.
Help please😁
Here is my latest attempt

Coderslang_Master

Kevo could you post your code as text so that everyone can try to run it without having to retype everything?

Kevo

Apologies. Here we go

export const shortenByWords = (s, n) => {
  
let arr=s.split(''); // split s into array
let i, newArr,j,res;
if (arr.length>n){ //if s has to be shortened
  for(i=n;i<arr.length;i--){//loop through array in reverse
    if (arr[i]==' '){
      arr[i]='...';//change last space char to '...'
      j=i+1;
      break;
    }
  }
  newArr=arr.slice(0,j);
  res=newArr.join('');
}
else{//is s.length is less than n
  res=arr.join('');
}
return res;
}

Coderslang_Master

Kevo the problem is in the loop:

for(i=n;i<arr.length;i--) {
...
}

Consider a situation where the string length is 5, n is 3 and there are no spaces in the string.

Will this loop ever break?

Andru

Kevo
what was your mistake? please help

Kevo

Thanks so much! I fixed the loop and managed to cater to cases where there are no spaces but the string length is still greater than n.

Coderslang_Master

Kevo great job! I've found one corner case bug in our tests and fixed it as well 🙂

MohammadTalha

Kevo can you please share the solution that you find

Andru

Help I can't find the error

export const shortenByWords = (s, n) => {
if(s.legth > n) {
for(let i = n + 1; i >= 0; i--) {
if(s === ' '){
return s.slice(0, i) + '...'
}
}
} else {
return s
}
}

Kevo

Hi.
Have you been able to solve the issue?

Andru

Kevo No bro

Kevo

there's the spelling of length in your code
also in the if statement in your for loop, you used s, instead of s[i], which I'm guessing you meant.
Have you already tried these corrections?
Without these errors though, it looks like your code will return s whenever it encounters a character that isn't space, and s.length>n.

prodigy197

export const shortenByWords = (s, n) => {
let sLen = s.length;
let sArr = s.split(" ");
let cnt = sArr.length;
let charLen = 0;
let elem = '';
for (let i = 0; i < sArr.length; i++) {
charLen += sArr.length;
if(charLen >= n){
elem = sArr;
break;
}

}
if(sLen > n){
if(elem === ''){
return s.slice(0, n)+'...';
}else{
let countElem = elem.length;
return s.slice(0, s.indexOf(elem)+countElem);
}
}
return s.slice(0, n);
}

MohammadTalha

export const shortenByWords = (s, n) => {