Task 1093

Jesse

Hi there, I am usure of what I am doing wrong, when I run my code it seems ok, I get the userId back however, I do not pass the test "3. getUser should find the user by id and resolve the Promise with it"

import { loadData } from './storage.js';

export const getUser = (userId) => new Promise((resolve, reject) => {
  //check userId and reject if it's missing
  if (!userId) {
    reject(new Error('user ID is missing'));
  } else {
    setTimeout(() => {
      //use loadData and resolve with the user object if the id is present
      let users = loadData;
      let i;
      if (userId === true && userId === users[i].id) {
       userId = users[i];
       return Promise.all(loadData.map(users[i]))
      }
      resolve(userId);
      return {};
    }, 200);
  }
});

Jesse

Jesse Or is the below more along the correct path? It returns the same failed test: 3. getUser should find the user by id and resolve the Promise with it

import { loadData } from './storage.js';

export const getUser = (userId) => new Promise((resolve, reject) => {
  //check userId and reject if it's missing
  if (!userId) {
    reject(new Error('user ID is missing'));
  } else {
    setTimeout(() => {
      //use loadData and resolve with the user object if the id is present
      getUser(loadData()).then((response) => console.log(response))
      resolve(userId);
      return {};
    }, 200);
    
  }
});

I realize the above code is not what you're looking for (I've seen the result 🙂 ), I'm just wondering if this is down the right path?

Coderslang_Master

Jesse the first example makes more sense to me, even though there are some problems with it.

Start by fixing this line:

let users = loadData;

loadData is a function, so you need to call it in order to get the users array.

Jesse

Coderslang_Master I can't seem to move forward with this. I am not sure what it is that I am not understanding.

import { loadData } from './storage.js';

export const getUser = (userId) => new Promise((resolve, reject) => {
  //check userId and reject if it's missing
  if (!userId) {
    reject(new Error('user ID is missing'));
  } else {
     //use loadData and resolve with the user object if the id is present
    setTimeout(() => { 
     loadData();
      for (let i = 0; i < users.length; i++) {
        if (users[i].id === userId) {
          userId = users[i].id
        }
        
      }
      resolve(loadData(userId));
      return {};
    }, 200);
  }  
});

Coderslang_Master

Jesse you haven't defined users, so there's no way it could work.

Here's your code with some of my changes and comments:

import { loadData } from './storage.js';

export const getUser = (userId) => new Promise((resolve, reject) => {
  //check userId and reject if it's missing
  if (!userId) {
    reject(new Error('user ID is missing'));
  } else {
    //use loadData and resolve with the user object if the id is present
    setTimeout(() => {
      // define users constant and set it equal to loadData().users
      const users = loadData().users;
      for (let i = 0; i < users.length; i++) {
        if (users[i].id === userId) {
          // resolve the promise with the matching user
          resolve(users[i]);
        }
      }
    }, 200);
  }
});