This works as intended but I am still getting errors on Submit: Errors: Details isShortWord(s) should return a boolean isShortWord(s) should return true if s is a single word with less than 10 characters isShortWord(s) should return false if s has a space in it or has more than 10 characters My function in functions.js export const isShortWord = (s) => { if (s.length < 10 && s.indexOf(' ') == -1) return (n) => { return n; }; }; Output: [ 'good', 'things', 'happen', 'if', 'you', 'do' ] I put a space in the word happen and was removed from the list as well. Removed the space and it is displayed. Your assistance is required please.

Task 151

Gazzooks

This works as intended but I am still getting errors on Submit:

Errors:
Details

isShortWord(s) should return a boolean
isShortWord(s) should return true if s is a single word with less than 10 characters
isShortWord(s) should return false if s has a space in it or has more than 10 characters

My function in functions.js
export const isShortWord = (s) => { if (s.length < 10 && s.indexOf(' ') == -1) return (n) => { return n; }; };
Output:
[ 'good', 'things', 'happen', 'if', 'you', 'do' ]

I put a space in the word happen and was removed from the list as well. Removed the space and it is displayed.

Your assistance is required please.

Coderslang_Master

Gazzooks right now isShortWord(n) return a function and not a boolean. Start by fixing this issue and make sure the logic stays intact.

Gazzooks

Coderslang_Master
I am having a hell of a time trying to understand closures. I do understand that a closure is the combination of a function and the lexical environment within which that function was declared.

Meaning that values defined in the first (outer function) are available for use in a subsequent function inside the outer function.

I've looked online and examined how the filter function works - it looks at each word in the array and based on the function in function.js it returns all the words that match based on the criteria defined in the function(closure).

But for tasks 151 and 154, I just dont seem to be able to produce a boolean result.

How can I return a boolean (True || False) in the second function.

in both tasks I get the desired results but fails because it's not returning a boolean.

Coderslang_Master

Gazzooks

Here's your origina code that returns a function

export const isShortWord = (s) => {
  if (s.length < 10 && s.indexOf(' ') == -1)
  return (n) => {
    return n;
  };
};

Here's an updated code that returns a boolean:

export const isShortWord = (s) => {
  if (s.length < 10 && s.indexOf(' ') == -1) {
    return true;
  } else {
    return false;
  }
}

Or you can make it even shorter if you wish:

export const isShortWord = (s) => {
  return s.length < 10 && s.indexOf(' ') == -1;
}

In this specific task there you don't need to overcomplicate a solution with closures.

Gazzooks

Coderslang_Master
Thank you, I guess I was getting wrapped around the axle for this and over complicating the required code.

I DO appreciate you taking the time to explain in detail, a response to my help request.

EDIT
I must say, once I stepped back and had an uncomplicated view of the code provided and the solution required, I could faithfully complete the problem much easier than before. I had 4 outstanding tasks and blazed through them with little to no difficulty.

Coderslang_Master

Gazzooks there will be times and places when you just can't get away without using closures, but not this time. Good job.