Task 132

Mitch

I am completely lost, I don't think we have seen yet how to approach this.

Localization
Fix the function getLocale.
It should return userConfig.locale if it's found in knownLocales.
Otherwise, it should return the string en.

my code so far:

export const getLocale = (userConfig, knownLocales) => {
  for (let i = 0; i < knownLocales.length; i++){
    if (userConfig.locale === knownLocales){
      return userConfig.locale;
    } else {
      return 'en'
    }}};

Mitch

@Coderslang_Master Could you help me out with this 1, please?

Hacktinium

Mitch did you manage to figure this one out?
What was your solution?

I had exactly the same issue, where the 'else' statement was cutting my loop short, so I did this instead:

export const getLocale = (userConfig, knownLocales) => {
	for (let i = 0; i < knownLocales.length; i++) {
		if (userConfig.locale === knownLocales[i]) {
			return userConfig.locale;
		}
		if (i === knownLocales.length - 1) {
			return "en";
		}
	}
};

So basically, if i increments as far as the final value in the array ("fr" in this case)), return the string 'en'.

And no, this doesn't 'cut off' the possibility of returning the last value of the knownLocales array if it happens to match the userConfig.locale, because it will run AFTER the for loop has checked for that. I tested just to make sure 🙂

...I was hoping to come up with a more elegant solution, but this is the best I could come up with for now!

Would love to hear what you did!

Coderslang_Master

@Mitch the problem is that your loop runs only once.

The root cause of the issue is here:

    if (userConfig.locale === knownLocales){
      return userConfig.locale;
    } else {
      return 'en'
    }

Hacktinium

p.s. Realised this was overkill, and could have just left it as:

export const getLocale = (userConfig, knownLocales) => {
	for (let i = 0; i < knownLocales.length; i++) {
		if (userConfig.locale === knownLocales[i]) {
			return userConfig.locale;
		}
	}
	return "en";
};

...just be sure to move the return statement outside of the loop and if statement,
but keep it within the function!